Fix #4446: Inline implementation of PF methods into its anonymous class #4604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
allanrenucci
force-pushed
the
fix-4446
branch
3 times, most recently
from
e13cd9f to
6bafeb0
Compare
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 1, 2018
When we create a symbol in a DenotationTransformer, we cannot safely create it at phase `thisPhase.next` since this can lead to cycles. This is why we created extension methods at phase `thisPhase`, but they're not really valid at that point since they're only entered in their owner once the transformer has been run. This lead to stale symbol errors which were worked around in 51a458e but the fix is incomplete and does not work with scala#4604 because that PR moves the ExtensionMethods phase around. This commit removes all the workarounds and uses a simpler solution: create the symbols at phase `thisPhase` but set their validity period to match the validity of the owner transformed denotation.
allanrenucci
force-pushed
the
fix-4446
branch
3 times, most recently
from
5ec2ab0 to
0025a60
Compare
smarter
approved these changes
Jun 12, 2018
There was a problem hiding this comment.
It'd be nice to add a documentation comment to toPartialFunction that shows what transformation is being done with an example, a bit like the comment on top of https://github.com/lampepfl/dotty/blob/master/compiler/src/dotty/tools/dotc/transform/VCInlineMethods.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.